test: remove redundant using in cctest#14739
Closed
XadillaX wants to merge 1 commit intonodejs:masterfrom
Closed
Conversation
addaleax
approved these changes
Aug 10, 2017
danbev
approved these changes
Aug 10, 2017
cjihrig
approved these changes
Aug 10, 2017
mscdex
added
the
c++
lpinca
approved these changes
Aug 10, 2017
tniessen
approved these changes
Aug 10, 2017
benjamingr
approved these changes
Aug 10, 2017
jasnell
approved these changes
Aug 10, 2017
aqrln
approved these changes
Aug 11, 2017
TimothyGu
approved these changes
Aug 11, 2017
Member
TimothyGu
left a comment
TimothyGu
left a comment
There was a problem hiding this comment.
Fine with me if fine with CI.
refack
approved these changes
Aug 11, 2017
Contributor
|
When I see stuff like this, I makes me think we need a stronger CPP linter (or stop ignoring compilation warnings) 🤔 |
addaleax
pushed a commit
that referenced
this pull request
Aug 11, 2017
PR-URL: #14739 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Member
|
This doesn’t need to wait 48 hours, landed in f422e38 |
addaleax
pushed a commit
that referenced
this pull request
Aug 12, 2017
PR-URL: #14739 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Sep 19, 2017
PR-URL: #14739 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 testpassesAffected core subsystem(s)
test, cctest